Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add some test cases for flow involving global and captured variables #18037

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

joefarebrother
Copy link
Contributor

@joefarebrother joefarebrother commented Nov 19, 2024

Adds test cases for cases involving flow through global variables and captured variables.
This checks whether modelling stdlib queue.Queue as a container would allow for the use case of dataflow between access of a shared Queue across separate threads, which is necessary for covering CVE-2024-32651. As-is it appears that such modelling would not be sufficient to detect flow in this case.

@joefarebrother joefarebrother added the no-change-note-required This PR does not need a change note label Nov 19, 2024
@joefarebrother joefarebrother requested a review from a team as a code owner November 19, 2024 16:47
@joefarebrother joefarebrother changed the title Python - Add some test cases for flow involving global variables and captured … Python: Add some test cases for flow involving globall and captured variables Nov 19, 2024
@joefarebrother joefarebrother changed the title Python: Add some test cases for flow involving globall and captured variables Python: Add some test cases for flow involving global and captured variables Nov 19, 2024
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these, they are quite illuminating!

@yoff yoff merged commit 44c94e0 into github:main Nov 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants